Upload SSI symbols to our backend #3452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3452 +/- ##
==========================================
- Coverage 61.89% 61.75% -0.14%
==========================================
Files 141 141
Lines 12501 12501
Branches 1633 1633
==========================================
- Hits 7737 7720 -17
- Misses 4042 4058 +16
- Partials 722 723 +1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Leiyks
reviewed
Oct 22, 2025
Comment on lines
+1467
to
+1482
| - export DATADOG_API_KEY_PROD=$(aws ssm get-parameter --region us-east-1 --name ci.async-profiler-build.api_key_public_symbols_prod_us1 --with-decryption --query "Parameter.Value" --out text) | ||
| - export DATADOG_API_KEY_STAGING=$(aws ssm get-parameter --region us-east-1 --name ci.async-profiler-build.api_key_public_symbols_staging --with-decryption --query "Parameter.Value" --out text) | ||
| - | | ||
| if [ -n "${DATADOG_API_KEY_STAGING:-}" ]; then | ||
| echo "Uploading debug symbols to Datadog..." | ||
| DATADOG_API_KEY=$DATADOG_API_KEY_STAGING DATADOG_SITE=datad0g.com DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload --disable-git ./build | ||
| else | ||
| echo "DATADOG_API_KEY_STAGING not set, skipping Datadog symbol upload" | ||
| fi | ||
| - | | ||
| if [ -n "${DATADOG_API_KEY_PROD:-}" ]; then | ||
| echo "Uploading debug symbols to Datadog..." | ||
| DATADOG_API_KEY=$DATADOG_API_KEY_PROD DATADOG_SITE=datadoghq.com DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload --disable-git ./build | ||
| else | ||
| echo "DATADOG_API_KEY_PROD not set, skipping Datadog symbol upload" | ||
| fi |
There was a problem hiding this comment.
Don't we want an proper exit error when the API keys are not set ?
That would avoid having a silently failing job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the debug syms from the builds and uploads them.